Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for response time out issue during build #420

Merged
merged 92 commits into from
Jun 25, 2020
Merged
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
cc2da9a
fixed resnet152 custom handler to work with GPU
harshbafna Apr 23, 2020
e4d1ee0
issue template
dhaniram-kshirsagar Apr 27, 2020
4fe6967
Moving issue templates to root folder per pull request template
dhaniram-kshirsagar Apr 27, 2020
fb39c6f
adding feature request template
dhaniram-kshirsagar Apr 27, 2020
5c5af7b
Minor changes related to sections and names.
dhaniram-kshirsagar Apr 27, 2020
5f54f7f
Update feature_template.md
dhaniram-kshirsagar Apr 27, 2020
06b25c2
Update bug_template.md
dhaniram-kshirsagar Apr 27, 2020
a9b80b1
doc template
dhaniram-kshirsagar Apr 29, 2020
a883ed2
Merge branch 'issue_templates' of https://github.com/pytorch/serve in…
dhaniram-kshirsagar Apr 29, 2020
92ffc2f
minor changes
dhaniram-kshirsagar Apr 29, 2020
3b84c1b
Minor changes to upload custom model or handler
dhaniram-kshirsagar Apr 29, 2020
b49ea57
Merge pull request #256 from pytorch/issue_153
maaquib Apr 30, 2020
14dc834
Merge branch 'staging_0_1_1' into issue_templates
mycpuorg Apr 30, 2020
9e06b12
issue templates (#273)
dhaniram-kshirsagar Apr 30, 2020
e8a2c75
Fixes #205 - Docker install not finding GPUs (#262)
dhanainme Apr 30, 2020
0593266
Merge remote-tracking branch 'origin/master' into staging_0_1_1
maaquib May 2, 2020
e6771f7
Fix pylint issue (#163)
harshbafna May 2, 2020
286a284
Updated exception handling for worker threads shutdown. (#172)
harshbafna May 2, 2020
71681cb
changes for Homebrew issue 98 (#126)
mjpsl May 2, 2020
45b17f5
added changes to clean model loaded through URL from model store on u…
harshbafna Apr 7, 2020
c544197
added UTs
harshbafna Apr 7, 2020
5caca0e
Moving the plugins SDK to org.pytorch. Added plugins example. (#261)
vdantu May 4, 2020
f5008c7
Added model zoo (#299)
harshbafna May 4, 2020
2e4844b
Removed snapshot dependency on model (#152)
dhaniram-kshirsagar May 7, 2020
3934cd5
Regression Tests Suite - AWS Code Build Infra - Initial Commit for #5…
dhanainme May 12, 2020
c41bc1d
Issue 312 install from src (#322)
dhanainme May 12, 2020
ec9ce2e
fix for macos script (#338)
dhaniram-kshirsagar May 13, 2020
6f1ece3
Move Issue Template to .github dir
dhanainme May 14, 2020
3fcdbb5
Updated sanity script to use install_from_src_ubuntu script (#350)
harshbafna May 16, 2020
9866cd0
Merge branch 'staging_0_1_1' into issue_templates
dhanainme May 16, 2020
a9b5660
Corrected HTTP response code for Model version does not exists except…
May 16, 2020
cc535bc
Corrected paths in command and added notes (#354)
mjpsl May 16, 2020
770dee8
Refactored UT for better reporting (#159)
harshbafna May 18, 2020
d720e3b
Huggingface Transformers generalization (#302)
HamidShojanazeri May 18, 2020
07a408b
added waveglow example (#258)
harshbafna May 18, 2020
74ee1c7
Merge branch 'staging_0_1_1' into issue_templates
maaquib May 18, 2020
d96ab79
made build suite compatible with latest gradle (#348)
harshbafna May 18, 2020
aff763b
moved env section after context
dhaniram-kshirsagar May 19, 2020
545b2ea
Deleting redundant ISSUE_TEMPLATE at root dir
May 19, 2020
6de660b
Merge branch 'staging_0_1_1' into issue_templates
maaquib May 19, 2020
42174a8
Fix typo in scripts/install_from_src_macos
maaquib May 19, 2020
e90a0bc
Merge branch 'staging_0_1_1' into issue_templates
maaquib May 19, 2020
9e6aab4
Merge branch 'issue_templates' into staging_0_1_1
maaquib May 19, 2020
305a211
Corrected OpenApi description (#328)
shivamshriwas May 20, 2020
7d5d9be
Regression suite fixes and added test cases (#344)
shivamshriwas May 20, 2020
cff1daf
Fix typo in mnist readme (#330)
takp May 20, 2020
33727ed
Fixed typo in ab installation. (#327)
alvations May 20, 2020
234a65c
Setup Nightly Build for TorchServe (#371)
dhanainme May 20, 2020
7a87176
Fix for intermittent gradle build failure (#352)
dhaniram-kshirsagar May 20, 2020
b32a15c
documentation: Remove redundant curl options in example (#336)
lanpa May 20, 2020
7844a11
Corrected port number validation range (#304)
shivamshriwas May 21, 2020
7db018b
Fixes version number reporting for TorchServe (#360)
shivamshriwas May 21, 2020
db0fb3c
fixes installation script exits without error if no java present on m…
harshbafna May 21, 2020
c698540
Dockerfile enhancements (#308)
dhaniram-kshirsagar May 21, 2020
3343b14
Updated configuration.md for missing config properties (#337)
shivamshriwas May 21, 2020
ef0e453
Adding missing document links to README (#379)
maaquib May 21, 2020
6bd4460
Maven tests should output only errors (#326)
vdantu May 22, 2020
f08d6a8
fixed code for build failure in python virtual environment (#341)
harshbafna May 22, 2020
ca9d97a
updated object detector handler to use only default cuda device for t…
harshbafna May 22, 2020
2ae95a1
Adding a barebones ec2 template to run torchserve on ubuntu (#301)
maaquib May 22, 2020
de258cf
Rebase for #365 (#389)
maaquib May 22, 2020
9658912
Document the docker settings for running in production mode (#388)
dhanainme May 23, 2020
9b60433
Huggingface transformers integration test (#382)
HamidShojanazeri May 27, 2020
7cda83e
Updated docker README.md (#401)
dhaniram-kshirsagar May 27, 2020
eb16fb3
Fixed response status message for inferencing on model with zero work…
mjpsl May 27, 2020
210ee6f
made model server port tests independent (#396)
harshbafna May 27, 2020
7dc8467
Added backend profiling and fixed benchmark's install dependency scri…
harshbafna May 29, 2020
ff59acb
Add sphinx directory and conf.py (#274)
May 30, 2020
9cfa9ac
fix for response time out issue during build
harshbafna Jun 1, 2020
559f34d
Image classifier example readme fixes (#405)
HamidShojanazeri Jun 1, 2020
5270583
Merge branch 'staging_0_1_1' into issue_417
harshbafna Jun 2, 2020
a414534
Resolve Merge Conflicts
dhanainme Jun 2, 2020
2591448
Porting memory fix changes to TorchServe (#422)
maaquib Jun 2, 2020
effef0c
Benchmark documentation fix (#425)
dhanainme Jun 2, 2020
4968865
Merge branch 'staging_0_1_1' into issue_417
dhaniram-kshirsagar Jun 5, 2020
0794dab
.circleci: Add initial circleci configuration (#431)
seemethere Jun 5, 2020
be6a087
Torchscript support huggingface transfrmers (#421)
HamidShojanazeri Jun 5, 2020
8b67e7a
Integration test huggingface transfromers torchscript support (#433)
HamidShojanazeri Jun 5, 2020
c69a650
Merge branch 'staging_0_1_1' into issue_417
harshbafna Jun 6, 2020
c8f8682
Apachebench benchmark - cleanup script / documentation
Jun 8, 2020
30195b0
Revert "Apachebench benchmark - cleanup script / documentation"
Jun 8, 2020
793d744
Documentation updates for clarity on Eager mode / Torch scripted mode…
dhanainme Jun 8, 2020
c456164
Apachebench benchmarking - Script / Documentation updates (#438)
dhanainme Jun 8, 2020
f11080e
Merge branch 'staging_0_1_1' into issue_417
dhaniram-kshirsagar Jun 9, 2020
48dddc2
Adding system diagram and brief explanation of workings (#413)
maaquib Jun 10, 2020
f0f1c24
Merge branch 'staging_0_1_1' into issue_417
harshbafna Jun 10, 2020
61d863d
Added TODO statement
harshbafna Jun 10, 2020
e708c80
Merge branch 'master' into issue_417
harshbafna Jun 19, 2020
6d5ba63
rebased to master
harshbafna Jun 19, 2020
44f75fa
Merge branch 'issue_417' of https://github.com/pytorch/serve into iss…
harshbafna Jun 19, 2020
91c89a5
rebased to master
harshbafna Jun 19, 2020
93194dd
Merge branch 'master' into issue_417
harshbafna Jun 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import io.netty.channel.EventLoopGroup;
import io.netty.handler.codec.http.HttpResponseStatus;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
Expand Down Expand Up @@ -117,13 +118,15 @@ public CompletableFuture<HttpResponseStatus> modelChanged(Model model, boolean i
// -> This may nullify process object per destroyForcibly doc.
if (workerProcess != null && workerProcess.isAlive()) {
boolean workerDestroyed = false;
workerProcess.destroyForcibly();
try {
// TODO : Add OS specific handling for windows support.
String cmd = String.format("kill -9 %s", workerProcess.pid());
maaquib marked this conversation as resolved.
Show resolved Hide resolved
Process workerKillProcess = Runtime.getRuntime().exec(cmd, null, null);
workerDestroyed =
workerProcess.waitFor(
workerKillProcess.waitFor(
configManager.getUnregisterModelTimeout(),
TimeUnit.SECONDS);
} catch (InterruptedException e) {
} catch (InterruptedException | IOException e) {
logger.warn(
"WorkerThread interrupted during waitFor, possible async resource cleanup.");
future.complete(HttpResponseStatus.INTERNAL_SERVER_ERROR);
Expand Down