Add request envelope to support Multiserving frameworks #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated custom resnet and mnist handlers - update docs
- removed stale Transformer_readme.md
Refactor BaseHandler
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
maaquib
requested changes
Nov 20, 2020
There was a problem hiding this comment.
@abishekchiffon Seeing failures when running the unit test python -m pytest test_envelopes.py
========================================================================= short test summary info ==========================================================================
ERROR test_envelopes.py::test_json - RuntimeError: Missing the model.pt file
ERROR test_envelopes.py::test_json_batch - RuntimeError: Missing the model.pt file
ERROR test_envelopes.py::test_json_double_batch - RuntimeError: Missing the model.pt file
ERROR test_envelopes.py::test_body - RuntimeError: Missing the model.pt file
======================================================================= 1 passed, 4 errors in 0.55s ========================================================================
frontend/server/src/main/java/org/pytorch/serve/util/codec/ModelRequestEncoder.java
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
maaquib
approved these changes
Nov 20, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
chauhang
approved these changes
Nov 23, 2020
dhanainme
approved these changes
Nov 23, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Lusk-Liu
added a commit
to Lusk-Liu/serve
that referenced
this pull request
Nov 24, 2020
Add request envelope to support Multiserving frameworks (pytorch#749)
6 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the wrapper feature to help Multiserving frameworks.
The envelope parses request from multiple Model serving frameworks like Seldon, KFServing, without any modifications in the handler code.
This PR builds on top of the PR #521 from Htappen
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
-Additional units added to ts/torch_handler/unit_tests.
-Executed end to end flow and verified following
Gradle build logs :build_gradle_411_envelope.log
Unit test logs: unit_tests_411_envelope.log
Regression suite logs: regression_test_411_envelope.log
Checklist: