-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fix for Issue 860, warn about OOME when building Docker image #871
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Description
When creating a Docker image that builds TorchServe from source, one needs at least 4GB of RAM allocated to the container. If too little RAM is allocated, OOMEs cause installation (specifically pip's installation of PyTorch, the package for which is >700MB) to fail with an uninformative error message ("Killed").
This PR adds a note to the documentation for setting up the KFServing Docker image recommending a 4GB minimum RAM allocation.
Fixes #860
Type of change
This change is a documentation update
Feature/Issue validation/testing
The instructions to build the Docker image fail (on my Mac running macOS 10.15.7) if too little RAM is allocated, but succeed consistently when there's sufficient memory. This has been tested multiple times.
Checklist: