Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix for Issue 860, warn about OOME when building Docker image #871

Merged
merged 2 commits into from
Dec 11, 2020
Merged

Doc fix for Issue 860, warn about OOME when building Docker image #871

merged 2 commits into from
Dec 11, 2020

Conversation

fbbradheintz
Copy link
Contributor

Description

When creating a Docker image that builds TorchServe from source, one needs at least 4GB of RAM allocated to the container. If too little RAM is allocated, OOMEs cause installation (specifically pip's installation of PyTorch, the package for which is >700MB) to fail with an uninformative error message ("Killed").

This PR adds a note to the documentation for setting up the KFServing Docker image recommending a 4GB minimum RAM allocation.

Fixes #860

Type of change

This change is a documentation update

Feature/Issue validation/testing

The instructions to build the Docker image fail (on my Mac running macOS 10.15.7) if too little RAM is allocated, but succeed consistently when there's sufficient memory. This has been tested multiple times.

Checklist:

  • n/a Have you added tests that prove your fix is effective or that this feature works?
  • n/a New and existing unit tests pass locally with these changes?
  • n/a Has code been commented, particularly in hard-to-understand areas?
  • [√] Have you made corresponding changes to the documentation?

@fbbradheintz
Copy link
Contributor Author

@maaquib maaquib requested review from maaquib and dhanainme December 11, 2020 17:34
@maaquib maaquib added this to the v0.3.0 milestone Dec 11, 2020
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 75940f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 75940f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 75940f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 74deada
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 74deada
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 74deada
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@maaquib maaquib merged commit 3ff2119 into pytorch:master Dec 11, 2020
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 74deada
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-win
  • Commit ID: 74deada
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 74deada
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KFServing instructions fail on Docker build
4 participants