Support for Users to provide their own Env Vars to Build Pipelines #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@osalpekar is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
seemethere
reviewed
Dec 12, 2022
3 tasks
Co-authored-by: Eli Uriegas <1700823+seemethere@users.noreply.github.com>
facebook-github-bot
pushed a commit
to pytorch/data
that referenced
this pull request
Dec 20, 2022
Summary: Added Linux Wheels workflow. The workflow will run in shadow mode without upload binaries. ### Changes - Added Linux Wheels workflow - Added Linux Conda workflow ### TODO - [x] Add the `BUILD_S3` env variable. Depend on the PR pytorch/test-infra#1269 - [x] Fixed smoke tests issue for Linux Conda - pytorch/test-infra#1292 - [x] Add smoke test - #923 Pull Request resolved: #921 Reviewed By: ejguan Differential Revision: D42095186 Pulled By: NivekT fbshipit-source-id: d9fd667b593706347aef9c7eb41d9c03ba1c314d
|
Already handled by #1297. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be useful for xFormers adoption: facebookresearch/xformers#573, and others like torch/data. Can clean up much domain-specific logic in the existing workflows with this as well.
The script provided to the
env-var-scriptarg would have to be formatted as follows:This PR only adds this for Linux Wheels, though we can add this for everything afterwards. We merge the env var script with the
BUILD_ENV_FILEscript created bypytorch-pkg-helpersso we only need to source one file before the critical build steps.