Support an optional job name filter (regex) in the OSS alerting #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
seemethere
approved these changes
Feb 4, 2023
malfet
approved these changes
Feb 4, 2023
atalman
approved these changes
Feb 6, 2023
Co-authored-by: Nikita Shulga <nshulga@fb.com>
izaitsevfb
added a commit
that referenced
this pull request
Feb 10, 2023
…2681) Brunt of the work for pytorch/pytorch#93991 Changes: 1. Adds a script (`binary_size_validation.py `) to perform wheel size fetching and validation using given rules. 2. Includes the specific job pattern from the builder repo to create alerts. 3. Fixes a minor bug in `check_alerts.py` (regression from #2109) A separate PR will schedule the script periodic execution in the pytorch/builder repo (TODO). The builder repo is chosen as compromise, as `test-infra` doesn't have HUD enabled as of now (alerts do not work). ---- ### Brief docs for `binary_size_validation.py ` (separate readme is included): #### Installation ```bash pip install -r requirements.txt ``` #### Usage ```bash # print help python binary_size_validation.py --help # print sizes of the all items in the index python binary_size_validation.py --url https://download.pytorch.org/whl/nightly/torch/ # fail if any of the torch2.0 wheels are larger than 900MB python binary_size_validation.py --url https://download.pytorch.org/whl/nightly/torch/ --include "torch-2\.0" --threshold 900 # fail if any of the latest nightly pypi wheels are larger than 750MB python binary_size_validation.py --include "pypi" --only-latest-version --threshold 750 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a prerequisite for pytorch/pytorch#93991 adding the possibility to specify a job name filter for the OSS alert generation mechanism.
The idea is to be able to specify
JOB_NAME_REGEXintest-infra/.github/workflows/check-alerts.yml
Line 28 in e194ede