Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable alert checking in builder/builder #3765

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Temporarily disable alert checking in builder/builder #3765

merged 1 commit into from
Feb 14, 2023

Conversation

izaitsevfb
Copy link
Contributor

Quick mitigation for #2681 (comment)

Next steps: fix the check_alerts script.

@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
torchci ⬜️ Ignored (Inspect) Feb 14, 2023 at 6:27PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2023
@izaitsevfb izaitsevfb merged commit 8ed79e4 into main Feb 14, 2023
@izaitsevfb izaitsevfb deleted the disable-alerts-in-builder-repo branch February 14, 2023 18:29
@izaitsevfb izaitsevfb mentioned this pull request Feb 14, 2023
Merged
izaitsevfb added a commit that referenced this pull request Feb 14, 2023
@izaitsevfb
Re-enable alert checking in pytorch/builder (#3768)
6c47375 
Reverts #3765, re-enabling the
alerts in `pytorch/builder`, since the underlying issue is fixed in
#3766.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

@kit1980 kit1980 kit1980 approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@izaitsevfb @kit1980 @huydhn @facebook-github-bot