Download fix #1366
Merged
Download fix #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1366
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 5747a71 with merge base 5da240a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
gabe-l-hart
force-pushed
the
download-fix
branch
2 times, most recently
from
a74ddc9 to
0c14af5
Compare
Downloading a Mistral model fails because it includes multiple weight mapping files. The regression was introduced in commit `766bee9f4a1fcb187fae543a525495d3ff482097`. I'm unclear on the original intent, but perhaps the exception was meant to apply only to Granite models. This isn’t an ideal fix, but it does enable Mistral to be downloaded and used for chat. Signed-off-by: Sébastien Han <seb@redhat.com>
The previous logic didn't handle .bin files, so if a model (like mistral) has both .bin and .safetensors, it would download both. Branch: download-fix Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
This will not actually be needed for mistral with the fix in download to handle .bin files, but it may be needed for other models, so it's worth having. Branch: download-fix Signed-off-by: Gabe Goodhart <ghart@us.ibm.com>
gabe-l-hart
force-pushed
the
download-fix
branch
from
9a0b5fa to
5747a71
Compare
Jack-Khuu
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Looks solid to me, thanks for the follow up
@Gasoonjia @vmpuri Can one of yall sanity test then ship it?
vmpuri
pushed a commit
that referenced
this pull request
Feb 4, 2025
* fix: allow multiple weight mapping files for mistral Downloading a Mistral model fails because it includes multiple weight mapping files. The regression was introduced in commit `766bee9f4a1fcb187fae543a525495d3ff482097`. I'm unclear on the original intent, but perhaps the exception was meant to apply only to Granite models. This isn’t an ideal fix, but it does enable Mistral to be downloaded and used for chat. Signed-off-by: Sébastien Han <seb@redhat.com> * fix(download): Fix safetensors/bin/pth download logic The previous logic didn't handle .bin files, so if a model (like mistral) has both .bin and .safetensors, it would download both. Branch: download-fix Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> * fix(convert hf): Better logic to handle multiple weight mapping files This will not actually be needed for mistral with the fix in download to handle .bin files, but it may be needed for other models, so it's worth having. Branch: download-fix Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> --------- Signed-off-by: Sébastien Han <seb@redhat.com> Signed-off-by: Gabe Goodhart <ghart@us.ibm.com> Co-authored-by: Sébastien Han <seb@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1360
Replaces #1346
This is an updated fix for the root cause of the failure to download Mistral that was introduced in #1255