Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong mesh order #286

Closed
ad8e opened this issue Apr 30, 2024 · 1 comment · Fixed by #288
Closed

Wrong mesh order #286

ad8e opened this issue Apr 30, 2024 · 1 comment · Fixed by #288
Assignees
@wconstab @wanchaol

Comments

@ad8e
Copy link

ad8e commented Apr 30, 2024

torchtitan/torchtitan/parallelisms/__init__.py

Line 46 in d442743

[self.dp, self.tp, self.pp], ["dp", "tp", "pp"], strict=True

Should be PP DP TP. This matters for NUMA across nodes.
@wanchaol
Copy link
Contributor

good catch! submitting a fix soon

wanchaol added a commit that referenced this issue Apr 30, 2024
@wanchaol
fix 3d mesh order
abfcf76 
as titled, fixes #286
@wanchaol wanchaol mentioned this issue Apr 30, 2024
Merged
wanchaol added a commit that referenced this issue Apr 30, 2024
@wanchaol
fix 3d mesh order (#288)
e7f2d28 
as titled, fixes #286
tianyu-l pushed a commit to tianyu-l/torchtitan_intern24 that referenced this issue Aug 16, 2024
@wanchaol
fix 3d mesh order (pytorch#288)
79f8c17 
as titled, fixes pytorch#286
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this issue Aug 17, 2024
@wanchaol
fix 3d mesh order (pytorch#288)
a6d2625 
as titled, fixes pytorch#286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wconstab wconstab

@wanchaol wanchaol

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix 3d mesh order pytorch/torchtitan
3 participants
@wconstab @wanchaol @ad8e