Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable integration tests with a test tokenizer #259

Merged
merged 1 commit into from
Apr 23, 2024
Merged

reenable integration tests with a test tokenizer #259

merged 1 commit into from
Apr 23, 2024

Conversation

wanchaol
Copy link
Contributor

as titled, the test tokenizer borrowed from torchtune https://github.com/pytorch/torchtune/blob/main/tests/assets/tiktoken_small.model, where this small test model is offline generated from https://gist.github.com/ebsmothers/54b133dd87db6679b14318545aaa2de4 so it should have no correlation with any specific model/data

as titled, the test tokenizer borrowed from torchtune
https://github.com/pytorch/torchtune/blob/main/tests/assets/tiktoken_small.model,
where this small test model is offline generated from
https://gist.github.com/ebsmothers/54b133dd87db6679b14318545aaa2de4 so
it should have no correlation with any specific model/data
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Apr 23, 2024
Copy link
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for re-enabling integration test!

@wanchaol wanchaol merged commit e1c116a into main Apr 23, 2024
4 checks passed
@wanchaol wanchaol deleted the test_tok branch April 24, 2024 04:12
tianyu-l pushed a commit to tianyu-l/torchtitan_intern24 that referenced this pull request Aug 16, 2024
as titled, the test tokenizer borrowed from torchtune
https://github.com/pytorch/torchtune/blob/main/tests/assets/tiktoken_small.model,
where this small test model is offline generated from
https://gist.github.com/ebsmothers/54b133dd87db6679b14318545aaa2de4 so
it should have no correlation with any specific model/data
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
as titled, the test tokenizer borrowed from torchtune
https://github.com/pytorch/torchtune/blob/main/tests/assets/tiktoken_small.model,
where this small test model is offline generated from
https://gist.github.com/ebsmothers/54b133dd87db6679b14318545aaa2de4 so
it should have no correlation with any specific model/data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants