-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add safe-serialization to FullModelHFCheckpointer #1096
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1096
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 745573e with merge base ef6e196 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @jeffrey-fong! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
This is awesome, thanks @jeffrey-fong! Waiting for tests to pass, then I'll merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Looks like this was opened before #1095 was merged. Can you rebase? |
Sure it's done |
Context
What is the purpose of this PR? Is it to
Please link to any issues this PR addresses.
As mentioned in #931,
FullModelHFCheckpointer
saves model checkpoints as .pt files, which is not entirely compatible with HuggingFace Transformers, specifically in Text-Generation Inference (TGI). As a step towards making this repo more compatible with HuggingFace libraries, I propose this PR which allows saving of model checkpoint directly assafetensors
.Changelog
In this PR, I added the option to save model checkpoints as
safetensors
checkpoint forFullModelHFCheckpointer
. This will be done when the optionsafe-serialization
is set toTrue
. The option will default toFalse
if it is set specifically or not set at all.Example Config for checkpointer:
Test plan
Please make sure to do each of the following if applicable to your PR. (If you're not sure about any one of these just ask and we will happily help.)
pre-commit install
)pytest tests
pytest tests -m integration_test