Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add QAT tutorial #1105

Merged
merged 1 commit into from
Jul 19, 2024
Merged

[doc] Add QAT tutorial #1105

merged 1 commit into from
Jul 19, 2024

Conversation

andrewor14
Copy link
Contributor

@andrewor14 andrewor14 commented Jun 20, 2024

Screenshot 2024-06-20 at 6 30 42 PM

Copy link

pytorch-bot bot commented Jun 20, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1105

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9ab129f with merge base c1c9f30 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2024
@andrewor14
Copy link
Contributor Author

Note: This should be landed after #980, which is currently blocked on the torchao 0.3 release.

docs/source/tutorials/qat_finetune.rst Outdated Show resolved Hide resolved
docs/source/tutorials/qat_finetune.rst Outdated Show resolved Hide resolved
docs/source/tutorials/qat_finetune.rst Show resolved Hide resolved
docs/source/tutorials/qat_finetune.rst Show resolved Hide resolved
docs/source/tutorials/qat_finetune.rst Show resolved Hide resolved

.. note::

QAT in torchtune is currently not compatible with :code:`memory_efficient_fsdp_wrap`. This is a known issue and will be fixed in a future torchtune version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the hang issue, right? Would be interested to see if we still see it running on FSDP2

docs/source/tutorials/qat_finetune.rst Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.57%. Comparing base (52e3283) to head (9ab129f).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (52e3283) and HEAD (9ab129f). Click for more details.

HEAD has 3 uploads less than BASE | Flag | BASE (52e3283) | HEAD (9ab129f) | |------|------|------| ||4|1|
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1105       +/-   ##
===========================================
- Coverage   66.69%   26.57%   -40.12%     
===========================================
  Files         184      184               
  Lines        8578     8572        -6     
===========================================
- Hits         5721     2278     -3443     
- Misses       2857     6294     +3437     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RdoubleA RdoubleA merged commit ef3137e into pytorch:main Jul 19, 2024
29 checks passed
RdoubleA added a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants