-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Add QAT tutorial #1105
[doc] Add QAT tutorial #1105
Conversation
andrewor14
commented
Jun 20, 2024
•
edited
Loading
edited
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1105
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9ab129f with merge base c1c9f30 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Note: This should be landed after #980, which is currently blocked on the torchao 0.3 release. |
|
||
.. note:: | ||
|
||
QAT in torchtune is currently not compatible with :code:`memory_efficient_fsdp_wrap`. This is a known issue and will be fixed in a future torchtune version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the hang issue, right? Would be interested to see if we still see it running on FSDP2
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
===========================================
- Coverage 66.69% 26.57% -40.12%
===========================================
Files 184 184
Lines 8578 8572 -6
===========================================
- Hits 5721 2278 -3443
- Misses 2857 6294 +3437 ☔ View full report in Codecov by Sentry. |