Add missing quantize_base to llama 3.1 #1485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Llama 3.1 component_builders were missing quantize_base. I noticed that when finetuning all layers, QLoRA size was ~6.2GB, but when i finetuned only KV, it would take much more memory. Thats because the layers are not quantized when we don't train them.
With this PR, the base model stays 6.2GB regardless of the layers you are finetuning.
Test plan
Compare LoRA vs QLoRA when finetuning all layers and only QV. Expected behavior is for memory: LoRA_all > LoRA_QV > QLoRA_all > QLoRA_KV