Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no new cycles #1519

Merged
merged 1 commit into from
Sep 6, 2024
Merged

no new cycles #1519

merged 1 commit into from
Sep 6, 2024

Conversation

RdoubleA
Copy link
Contributor

@RdoubleA RdoubleA commented Sep 6, 2024

no new cycles, no new cycles no no no

Removes the last dependency on training from other modules. See #1421

Test plan

o______________o

Copy link

pytorch-bot bot commented Sep 6, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1519

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8f581a2 with merge base 8d2b46c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 6, 2024
Copy link
Contributor

@ebsmothers ebsmothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls god no more

@ebsmothers ebsmothers merged commit 7370c0c into pytorch:main Sep 6, 2024
15 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 27.11%. Comparing base (277fbf8) to head (8f581a2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
torchtune/datasets/_packed.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage   27.10%   27.11%           
=======================================
  Files         284      285    +1     
  Lines       13813    13814    +1     
=======================================
+ Hits         3744     3745    +1     
  Misses      10069    10069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants