Run unit tests against PyTorch nightlies as part of our nightly CI #1569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI was not running our unit tests against PyTorch nightlies at all, just our recipe tests.
Ideally, we should not run against PyTorch nightlies on every PR. This is because if PyTorch nightlies are broken it will block all our PRs until things are resolved. This is the reason that we run our recipe tests against the PyTorch nightlies each night. However, we currently do not run our unit tests against the PyTorch nightlies at all in our CI. This is not good.. one of our flex attention tests was broken for a couple days and there was no means of catching it.
So this PR adds unit tests to our nightly CI job that runs against PyTorch nightlies. We can also consider a job that runs against PyTorch nightlies on push to main too.. that way we can get quicker signal
Also I rename the file, job, etc from "Recipe tests" to "GPU tests" since recipe tests is no longer an accurate description.
Edit: after some discussions with @RdoubleA I am gonna enable testing against nightlies on push to main (but still not on PRs). Oh also now that I realize (a) how to do conditional matrix elements, and (b) how similar our two gpu test workflow files are, I am consolidating them into one.