config changes #1733
Merged
config changes #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 1, 2024 12:31
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1733
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9a94468 with merge base 55b4814 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
RdoubleA
approved these changes
Oct 1, 2024
| @@ -14,6 +14,12 @@ | |||
| # tune run --nproc_per_node 8 full_finetune_distributed --config llama3/70B_full checkpointer.checkpoint_dir=<YOUR_CHECKPOINT_DIR> | |||
| # | |||
| # This config is only tested on an 8xA100 machine. | |||
| # | |||
| # !!!!!!!!!!!!! | |||
| # !!!!!!!!!!!!! | |||
There was a problem hiding this comment.
nit: I would take the !!!! out personally
There was a problem hiding this comment.
i am afraid that users would ignore it without the "!", and not understand why it crashes
| checkpoint_files: [ | ||
| hf_model_0001_0.pt | ||
| model.safetensors | ||
| ] | ||
| recipe_checkpoint: null | ||
| output_dir: /tmp/Qwen2-1.5B-Instruct-lora-finetune |
There was a problem hiding this comment.
should change output dir here
There was a problem hiding this comment.
i thought about it. Indeed in all of our configs we use the same output dir. I will make the change
RdoubleA
pushed a commit
that referenced
this pull request
Oct 2, 2024
Co-authored-by: Felipe Mello <felipemello@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Changelog
3 mains fixes:
extra:
added compile flag for llama. I should have done it in another PR, sorry/not sorry.
Test plan
ran the configs and saved ckpt