-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter_fn to all generic dataset classes and builders API #1789
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1789
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8ddc7bd with merge base 57ab583 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@RdoubleA @joecummings Require accurate review |
This looks great. Could you also add it to the multimodal datasets? |
Done. |
Revised. |
@RdoubleA Probably now is fine(fixed linting and docs was building on previous revisions). I have 3 PR-s opened yet, but let's start from here. |
@RdoubleA Finnaly! |
Context
What is the purpose of this PR? Is it to add filter_fn to all required dataset builders APIs and generics.
Please link to any issues this PR addresses.
Changelog
What are the changes made in this PR?
Test plan
Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.
pre-commit install
)pytest tests
pytest tests -m integration_test
UX
If your function changed a public API, please add a dummy example of what the user experience will look like when calling it.
Here is a docstring example
and a tutorial example
I'm not sure about all changes, so review is very glad here.
I have might missed something so added [WIP].