Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
_copy_tensor
was not needed and was added due to a misunderstanding on how pytorch internally handles tensor reference counting. The thinking was that we're creating a linear layer and want to save the bias, so we just deep clone the bias before returning it. This however is inaccurate, and its sufficient to just return a reference to the bias. This is because torch will internally bump the refcount to the bias's storage by 2, and when the function goes out of scope, we'll still have a reference count of 1 due to the returnedbias
variable.weight
.Changelog
_copy_tensor
Test plan