Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test name and also confirm unit tests run #68

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Fix test name and also confirm unit tests run #68

merged 1 commit into from
Dec 12, 2023

Conversation

gokulavasan
Copy link
Contributor

Minor fix, looks like the file name was incorrect. Fixing it and the import added 5 more unit tests (33 -> 38) to be discovered and run when I invoked pytest at the root dir.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2023
joecummings
joecummings approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@joecummings joecummings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

rohan-varma
rohan-varma approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@rohan-varma rohan-varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you! We should definitely have a linter in place in the future to catch these sort of issues.

@gokulavasan gokulavasan merged commit 33e31a1 into main Dec 12, 2023
1 check passed
@gokulavasan gokulavasan deleted the fix-transformer-decoder-test-name branch December 12, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joecummings joecummings joecummings approved these changes

@rohan-varma rohan-varma rohan-varma approved these changes

@pbontrager pbontrager Awaiting requested review from pbontrager

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gokulavasan @rohan-varma @joecummings @facebook-github-bot