Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix llama3 tutorial link #805

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix llama3 tutorial link #805

merged 1 commit into from
Apr 19, 2024

Conversation

kartikayk
Copy link
Contributor

Context

-As per title

Changelog

  • ...

Test plan

  • Local Docs Build

Copy link

pytorch-bot bot commented Apr 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/805

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cd9b9b3 with merge base a79554e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 19, 2024
@kartikayk kartikayk merged commit e72c9a6 into main Apr 19, 2024
24 checks passed
@joecummings joecummings deleted the fix_link branch April 19, 2024 16:28
@farshadghodsian
Copy link

Sorry to revive an old PR, but shouldn't this also be merged into Stable branch as most of the links to the tutorial pages including the post made in Reddit reference the stable branch which is still pointing to the wrong page for the Llama3 Tutorial: https://pytorch.org/torchtune/stable/#tutorials

@kartikayk
Copy link
Contributor Author

@farshadghodsian stable points to the released packaged (v0.1.1). This change should be available in main (https://pytorch.org/torchtune/main/#tutorials) and will get merged with stable in the next package release. Sorry for the confusion on this.

cc: @joecummings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants