Fix Gemma inference generation #810
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/810
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0a12cbe with merge base 41341fd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @Carolinabanana! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Done |
Context
Running generate.py for Gemma 2B gives the following error:
File "torchtune/modules/kv_cache.py", line 47, in update
assert input_pos.shape[0] == k_val.shape[2]
AttributeError: 'NoneType' object has no attribute 'shape'
Changelog
Re-add input_pos to modules/gemma/transformer.py to match the base transformer.py
This allows the config to successfully generate text.