Remove non-existant objects from __all__
#902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/902
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 82efe61 with merge base 437241f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vmoens
changed the title
__all__\__all__
ebsmothers
reviewed
Apr 30, 2024
torchtune/modules/peft/__init__.py
Outdated
| @@ -19,7 +19,6 @@ | |||
| "AdapterModule", | |||
| "get_adapter_params", | |||
| "set_trainable_params", | |||
| "validate_missing_and_unexpected_for_lora", | |||
There was a problem hiding this comment.
This one I think is still used? https://github.com/search?q=repo%3Apytorch%2Ftorchtune+validate_missing_and_unexpected_for_lora&type=code
There was a problem hiding this comment.
In my IDE it appeared as not linked but let me double check!
There was a problem hiding this comment.
Got it, it was not imported!
ebsmothers
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of objects are listed in
__all__but can't be found in the lib