Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - MarioRL Resize Bug #2650

Closed
alperenunlu opened this issue Nov 4, 2023 · 5 comments · Fixed by #2660
Closed

[BUG] - MarioRL Resize Bug #2650

alperenunlu opened this issue Nov 4, 2023 · 5 comments · Fixed by #2660
Assignees
Labels
bug docathon-h2-2023 rl Issues related to reinforcement learning tutorial, DQN, and so on

Comments

@alperenunlu
Copy link
Contributor

alperenunlu commented Nov 4, 2023

Add Link

mario_rl_tutorial.py

Describe the bug

On MarioRL Tutorial resize function gives warning in newer versions.

python intermediate_source/mario_rl_tutorial.py

UserWarning: The default value of the antialias parameter of all the resizing transforms > (Resize(), RandomResizedCrop(), etc.) will change from None to True in v0.17, in order to > be consistent across the PIL and Tensor backends. To suppress this warning, directly pass > antialias=True (recommended, future default), antialias=None (current default, which means False for Tensors and True for PIL), or antialias=False (only works on Tensors - PIL will still use antialiasing). This also applies if you are using the inference transforms from the models weights: update the call to weights.transforms(antialias=True).

Describe your environment

Platform: macOS
CUDA: no
PyTorch version: 2.1.0

cc @vmoens @nairbv @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

@alperenunlu alperenunlu added the bug label Nov 4, 2023
@alperenunlu
Copy link
Contributor Author

@svekars

@alperenunlu
Copy link
Contributor Author

/assigntome

Copy link

github-actions bot commented Nov 4, 2023

This issue does not have the correct label. Please pick an opened and unnasigned issue with the docathon-h2-2023 label.

@svekars svekars added the rl Issues related to reinforcement learning tutorial, DQN, and so on label Nov 6, 2023
@svekars
Copy link
Contributor

svekars commented Nov 6, 2023

@vmoens any thoughts?

@vmoens
Copy link
Contributor

vmoens commented Nov 7, 2023

As the warning says, the use of Resize should have the flag antialias=True. That should not impact the performance of the learning algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug docathon-h2-2023 rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants