Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable antialias on marioRL #2660

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Enable antialias on marioRL #2660

merged 1 commit into from
Nov 7, 2023

Conversation

alperenunlu
Copy link
Contributor

@alperenunlu alperenunlu commented Nov 7, 2023 •
edited by pytorch-bot bot
Loading

Fixes #2650

Description

Enabling antialias for compatibility with newer versions of PyTorch.

Checklist

  • The issue that is being fixed is referred in the description
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @vmoens @nairbv @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Nov 7, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2660

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ab2cfa0 with merge base 105e952 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars added the rl Issues related to reinforcement learning tutorial, DQN, and so on label Nov 7, 2023
@svekars svekars requested a review from vmoens November 7, 2023 18:28
vmoens
vmoens approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@alperenunlu
Copy link
Contributor Author

@vmoens thank you!!

@svekars svekars merged commit 88e017e into pytorch:main Nov 7, 2023
22 checks passed
@svekars svekars added the easy label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
bug cla signed docathon-h2-2023 easy rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - MarioRL Resize Bug
4 participants
@alperenunlu @vmoens @svekars @facebook-github-bot