Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mario_rl_tutorial.py #2381

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Update mario_rl_tutorial.py #2381

merged 5 commits into from
Jun 6, 2023

Conversation

neuralninja27
Copy link
Contributor

@neuralninja27 neuralninja27 commented Jun 1, 2023 •
edited by pytorch-bot bot
Loading

Fixes #1620

Description

Modified code to remove the CUDA out of memory error

Checklist

cc @vmoens @nairbv

@netlify
Copy link

netlify bot commented Jun 1, 2023 •
edited
Loading

✅ Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 09487bb
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/647f9cfc1b6b5900086b560a
😎 Deploy Preview https://deploy-preview-2381--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added CUDA Issues relating to CUDA rl Issues related to reinforcement learning tutorial, DQN, and so on docathon-h1-2023 A label for the docathon in H1 2023 easy and removed cla signed labels Jun 1, 2023
@svekars
Copy link
Contributor

svekars commented Jun 2, 2023

@neuralninja27 can you implement @vmoens suggestion?

@neuralninja27
Copy link
Contributor Author

@svekars sure I'll look into it

vmoens
vmoens approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for this!

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2381

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 09487bb:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars merged commit 6e0fd0a into pytorch:main Jun 6, 2023
@malfet malfet mentioned this pull request Oct 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carljparker carljparker carljparker left review comments

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CUDA Issues relating to CUDA docathon-h1-2023 A label for the docathon in H1 2023 easy rl Issues related to reinforcement learning tutorial, DQN, and so on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: CUDA error: out of memory while trying mario_rl_tutorial.py
5 participants
@neuralninja27 @svekars @carljparker @vmoens @facebook-github-bot