Fix cropping to include last column and last row #2384
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #876
Description
I have updated image cropping lines to include last row and column. Earlier the top index was from
[0, h - new_h)
whereh
is the height of the image andnew_h
is the height of the cropped image.Consider a case where
new_h = 3
andh = 4
. In this case, top index can only be 0 and hence the last row will never get started. To fix this, I have updatednp.random.randint
to sample from[0, h - new_h + 1)
for choosing last row and for chosing last column, I have update the func to sample from[0, w - new_w + 1)
Checklist