Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log-softmax unused issue #2420

Merged
merged 2 commits into from
Jun 9, 2023
Merged

Fix log-softmax unused issue #2420

merged 2 commits into from
Jun 9, 2023

Conversation

j3soon
Copy link
Contributor

@j3soon j3soon commented Jun 3, 2023

Fixes: #800

Description

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

@facebook-github-bot
Copy link
Contributor

Hi @j3soon!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify
Copy link

netlify bot commented Jun 3, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit b87f6e8
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/64837fbc64aea40008743572
😎 Deploy Preview https://deploy-preview-2420--pytorch-tutorials-preview.netlify.app/beginner/transformer_tutorial
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@svekars
Copy link
Contributor

svekars commented Jun 9, 2023

Please resolve the conflict

@svekars svekars added the docathon-h1-2023 A label for the docathon in H1 2023 label Jun 9, 2023
@svekars
Copy link
Contributor

svekars commented Jun 9, 2023

Will mark as docathon contribution.

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 9, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2420

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit b87f6e8:

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@svekars svekars merged commit 3b20fe6 into pytorch:main Jun 9, 2023
@j3soon j3soon deleted the explain-softmax branch June 12, 2023 01:29
@svekars svekars added the easy label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed docathon-h1-2023 A label for the docathon in H1 2023 easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

transformer_tutorial.py mentions log softmax even though it's not used.
4 participants