Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transformer_tutorial.py #2451

Merged
merged 3 commits into from
Jun 9, 2023
Merged

Update transformer_tutorial.py #2451

merged 3 commits into from
Jun 9, 2023

Conversation

NM512
Copy link
Contributor

@NM512 NM512 commented Jun 8, 2023

Fixes #1225

Description

  • Clarify the task addressed in this tutorial.
  • Add necessary package installation

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @pytorch/team-text-core @Nayef211

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 8, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2451

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1acbfc7:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@NM512 NM512 marked this pull request as draft June 8, 2023 13:59
@NM512 NM512 marked this pull request as ready for review June 8, 2023 13:59
@netlify
Copy link

netlify bot commented Jun 8, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit 1acbfc7
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/64835415dd2d2e000873ebf1
😎 Deploy Preview https://deploy-preview-2451--pytorch-tutorials-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @NM512

@svekars svekars merged commit 203f567 into pytorch:main Jun 9, 2023
svekars pushed a commit that referenced this pull request Jun 9, 2023
Co-authored-by: NM512 <morihira3513@gmailcom>
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docathon-h1-2023 A label for the docathon in H1 2023 easy module: torchtext
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seq2Seq Transformer Tutorial
4 participants