-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Attention in seq2seq_translation_tutorial AttnDecoderRNN #2452
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2452
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit eefd16b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
✅ Deploy Preview for pytorch-tutorials-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updated diagram @QasimKhan5x
Fixes #130
Description
.png
diagram that depicts the model to reflect the new oneencoder1
andattn_decoder1
withencoder
andattn_decoder
Also, in the current tutorial, the visualizations clearly show wrong usage of attention. By merging this pull request, the correct visual display of feature importance via attention will be shown.
Checklist
cc @pytorch/team-text-core @Nayef211