Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mario_rl_tutorial.py #2649

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Fix mario_rl_tutorial.py #2649

merged 3 commits into from
Nov 6, 2023

Conversation

alperenunlu
Copy link
Contributor

@alperenunlu alperenunlu commented Nov 4, 2023

Fixes #2335

Description

Removed copy.deepcopy method with appropriate torch methods on intermediate_source/mario_rl_tutorial.py file

Checklist

  • The issue that is being fixed is referred in the description
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @vmoens @nairbv @albanD @sekyondaMeta @svekars @carljparker @NicolasHug @kit1980 @subramen

Copy link

pytorch-bot bot commented Nov 4, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2649

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a500e06 with merge base 0f33d66 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

Hi @alperenunlu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@github-actions github-actions bot added core Tutorials of any level of difficulty related to the core pytorch functionality easy docathon-h2-2023 labels Nov 4, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@alperenunlu alperenunlu marked this pull request as draft November 4, 2023 22:06
@alperenunlu alperenunlu marked this pull request as ready for review November 4, 2023 22:06
@svekars svekars added the rl Issues related to reinforcement learning tutorial, DQN, and so on label Nov 6, 2023
@github-actions github-actions bot removed cla signed rl Issues related to reinforcement learning tutorial, DQN, and so on labels Nov 6, 2023
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes more sense to me too, thanks for this.

@svekars svekars merged commit 4eb4483 into pytorch:main Nov 6, 2023
17 checks passed
@alperenunlu alperenunlu deleted the marioRL-fix branch November 6, 2023 22:32
@svekars svekars mentioned this pull request Nov 7, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Tutorials of any level of difficulty related to the core pytorch functionality docathon-h2-2023 easy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tutorial to avoid use of copy.deepcopy()-Train a Mario-playing RL Agent
4 participants