-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added USB tutorial script #2676
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2676
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 2151259 with merge base 37462ab (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Hi @Hhhhhhao! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Fix typos
I fixed some typos from the grammar check. |
Add @NicolasHug as reviewer, in addition to @subramen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the suggestions are addressed, good to go from me! Thanks @Hhhhhhao for submitting this tutorial :)
advanced_source/usb_semisup_learn.py
Outdated
@@ -0,0 +1,223 @@ | |||
""" | |||
Semi-Supervised Learning using USB built upon Pytorch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace all occurrences of "Pytorch" with "PyTorch"
advanced_source/usb_semisup_learn.py
Outdated
Introduction | ||
------------ | ||
|
||
USB is a semi-supervised learning framework built upon Pytorch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include a few sentences about how USB uses PyTorch under the hood. This will increase confidence for PyTorch users to try out USB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
I have fixed the corresponding places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include this tutorial in the index.rst file
Example: 16e4f2a#diff-54a294a5d016e1a8e98bc95668ed84a99a9edd5c10394d9a2b1ee848006e98a7
Added USB to index file |
Execution time of this tutorial is 142 minutes - https://pytorch.org/tutorials/advanced/usb_semisup_learn.html. |
Hi, I found the image is not compiled well. Also the reference is messed up. Can I make a few changes regarding these issues? |
Fixes #2670
Description
Added USB tutorial script
Checklist
cc @datumbox @nairbv @fmassa @NicolasHug @YosuaMichael @sekyondaMeta @svekars @carljparker @kit1980 @subramen