Updated linalg functions in tensors_deeper_tutorial.py #2959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2933
Description
Hi, after reading #2933, there are a few things that I noted while attempting to solve this issue:
torch.cross
is more flexible and allows you for more complex cross products, I believe the expected behavior is usually the one fromtorch.linalg.cross
implementation. In this discussion it explains why blindly usingtorch.cross
can lead you to an intersting bug-hunting.torch.svd
is deprecated and will be removed in future pytorch release.torch.linalg.matmul
which actually callstorch.matmul
, but I think it would be better from a beginner user standpoint, to refer them totorch.linalg
for all linear algebra related operations.torch.linalg
docs.Checklist
cc @albanD