ignore error instead of using Union

pytorch · Sep 15, 2020 · 937b956 · 937b956
1 parent 54b6c14
commit 937b956
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/torchvision/models/googlenet.py b/torchvision/models/googlenet.py
@@ -1,6 +1,5 @@
 import warnings
 from collections import namedtuple
-from typing import Union
 import torch
 import torch.nn as nn
 import torch.nn.functional as F
@@ -194,11 +193,11 @@ def _forward(self, x):
         return x, aux2, aux1
 
     @torch.jit.unused
-    def eager_outputs(self, x: Tensor, aux2: Tensor, aux1: Optional[Tensor]) -> Union[GoogLeNetOutputs, Tensor]:
+    def eager_outputs(self, x: Tensor, aux2: Tensor, aux1: Optional[Tensor]) -> GoogLeNetOutputs:
         if self.training and self.aux_logits:
             return _GoogLeNetOutputs(x, aux2, aux1)
         else:
-            return x
+            return x   # type: ignore[return-value]
 
     def forward(self, x):
         # type: (Tensor) -> GoogLeNetOutputs

diff --git a/torchvision/models/inception.py b/torchvision/models/inception.py
@@ -1,6 +1,5 @@
 from collections import namedtuple
 import warnings
-from typing import Union
 import torch
 import torch.nn as nn
 import torch.nn.functional as F
@@ -189,11 +188,11 @@ def _forward(self, x):
         return x, aux
 
     @torch.jit.unused
-    def eager_outputs(self, x: torch.Tensor, aux: Optional[Tensor]) -> Union[InceptionOutputs, torch.Tensor]:
+    def eager_outputs(self, x: torch.Tensor, aux: Optional[Tensor]) -> InceptionOutputs:
         if self.training and self.aux_logits:
             return InceptionOutputs(x, aux)
         else:
-            return x
+            return x  # type: ignore[return-value]
 
     def forward(self, x):
         x = self._transform_input(x)