Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the "scipy" extra #1842

Closed
IRDonch opened this issue Jan 31, 2020 · 2 comments · Fixed by #1966
Closed

Document the "scipy" extra #1842

IRDonch opened this issue Jan 31, 2020 · 2 comments · Fixed by #1966

Comments

@IRDonch
Copy link

IRDonch commented Jan 31, 2020

Torchvision's setup.py defines a scipy extra that pulls in the scipy dependency that is needed by some of Torchvision's modules. This lets you use torchvision[scipy] as an argument to pip install, which is good, since it's a way to explicitly state that you're installing SciPy as a dependency of Torchvision.

However, this extra doesn't seem to be documented anywhere, so it's unclear whether doing pip install torchvision[scipy] is officially supported. It would be nice if this was documented in the README or elsewhere.

@fmassa
Copy link
Member

fmassa commented Feb 3, 2020

I agree. We haven't documented scipy (or pycocotools) because they are not hard-requirements, and only a few functions of torchvision depends on them.

But it might be good to document that somewhere, maybe in the functions that use them?

Can you send a PR improving the documentation?

@nvs-abhilash
Copy link
Contributor

@fmassa I have created a PR #1966 for this issue. Please let me know if anything else is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants