-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up the documentation of transforms #3071
Comments
Hi! In the cleanup process, if you guys find functional limitations of tensor transforms (i.e. something PIL can do that tensors can't), maybe I could work on them? |
Hi @voldemortX, you are very welcome to do so! I think we already mention these limitations on the transforms.py pydoc linked above, if you want to have a go. :) |
Cool! I'll investigate and summarize what can be done soon. |
@datumbox I checked the current documentation in transforms.py and found the following tensor limitations:
Maybe I can try something for 3 and 4, after some thorough investigation about interpolation modes. EDIT: |
@voldemortX Thanks for the deep dive! Great work flagging the issue on point 1, I'll update this ticket's description to include it. Unfortunately JIT still does not support Lambdas. Given that points 3 & 4 are quite big and not related to this very specific issue, I would recommend opening a RFC issue where you can outline the potential solutions and request feedback. Finally, if you are interested in fixing the problems listed in this issue, feel free to send a PR. |
At the moment I don't have a elegant workaround for interpolations modes, I think maybe if me or somebody want to do this, maybe it's better done in pytorch than in torchvision.
You mean clean-up the docs? I could do that in a bit. |
📚 Documentation
The methods in
functional_pil.py
andfunctional_tensor.py
are private but contain a lot of duplicate documentation that is not currently used. It's worth cleaning this up and updating the documentation onfunctional.py
to highlight potential differences or limitations between the two backends.Here is an example of how we typically highlight backend differences in TorchVision:
vision/torchvision/transforms/transforms.py
Lines 332 to 333 in 1b83f46
Moreover as per @voldemortX's comment (see #3071 (comment)), some of the limitations listed in the pydocs are inaccurate and they have already been resolved. These need to be corrected.
The text was updated successfully, but these errors were encountered: