Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cityscapes Dataset Extraction (Follow-up PR to #1066) #1068

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

RJT1990
Copy link
Contributor

@RJT1990 RJT1990 commented Jul 1, 2019

Incorporating @fmassa and @TheCodez feedback from #1066:

  • Now using the extract_archive function from dataset.utils
  • Now autoextracts the trainextra dataset if split='train_extra' is specified

@codecov-io
Copy link

codecov-io commented Jul 1, 2019

Codecov Report

Merging #1068 into master will increase coverage by 0.01%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   63.87%   63.88%   +0.01%     
==========================================
  Files          66       66              
  Lines        5295     5294       -1     
  Branches      797      798       +1     
==========================================
  Hits         3382     3382              
+ Misses       1683     1682       -1     
  Partials      230      230
Impacted Files Coverage Δ
torchvision/datasets/cityscapes.py 20% <16.66%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867e5b4...8c40a25. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should really have tests for Cityscapes (but this is a separate feature request altogether)

@TheCodez can you review this PR as well?

@TheCodez
Copy link
Contributor

TheCodez commented Jul 1, 2019

LGTM, thanks

@RJT1990
Copy link
Contributor Author

RJT1990 commented Jul 1, 2019

@fmassa : sounds good - I was going to submit a CamVid dataset PR so will write some new segmentation tests in that branch? (will submit later today)

@fmassa
Copy link
Member

fmassa commented Jul 1, 2019

@RJT1990 please send a separate PR for the tests, following the dummy datasets approach that we currently have in test_datasets.py. Thanks a lot!

@fmassa fmassa merged commit 4c56f42 into pytorch:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants