Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TorchHub tests to torchvision #1319

Merged
merged 2 commits into from
Sep 18, 2019
Merged

Conversation

fmassa
Copy link
Member

@fmassa fmassa commented Sep 9, 2019

Drop-in replacement for PyTorch Hub tests.

I only modified a few things:

  • assertObjectIn -> assertIn
  • SUM_OF_PRETRAINED_RESNET18_PARAMS = -12703.992365 -> -12703.99609375

@fmassa fmassa requested review from soumith and ailzhang September 9, 2019 14:23
@fmassa fmassa merged commit 0dd5588 into pytorch:master Sep 18, 2019
@fmassa fmassa deleted the add-torchhub-tests branch September 18, 2019 20:19
@codecov-io
Copy link

codecov-io commented Sep 19, 2019

Codecov Report

Merging #1319 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   65.52%   65.53%   +0.01%     
==========================================
  Files          75       75              
  Lines        5821     5821              
  Branches      892      892              
==========================================
+ Hits         3814     3815       +1     
+ Misses       1738     1737       -1     
  Partials      269      269
Impacted Files Coverage Δ
torchvision/transforms/transforms.py 80.39% <0%> (ø) ⬆️
torchvision/transforms/functional.py 71.26% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d5d425...d762d7a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants