-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cpp extensions in favor of torch ops #1348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1348 +/- ##
==========================================
- Coverage 65.5% 65.48% -0.03%
==========================================
Files 75 75
Lines 5819 5827 +8
Branches 892 892
==========================================
+ Hits 3812 3816 +4
- Misses 1737 1743 +6
+ Partials 270 268 -2
Continue to review full report at Codecov.
|
fmassa
force-pushed
the
remove-cpp-extensions
branch
from
September 18, 2019 14:39
ea893d3
to
ceafeb4
Compare
zhangguanheng66
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1322
Now we only use torch operators, which makes it possible for them to be available in torchscript.
I also handle the case of TorchHub support, because now instead of lazily importing the extensions, we unconditionally import the extensions at torchvision import time, but we don't fail hard if it's not available