Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation of crop functionals #1388

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Fix documentation of crop functionals #1388

merged 1 commit into from
Sep 30, 2019

Conversation

pmeier
Copy link
Collaborator

@pmeier pmeier commented Sep 30, 2019

Closes #1380 and supersedes #1323. Additionally to the docstrings, I refactored the variable names inside the functionals to make their meaning more clear.

fmassa
fmassa approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

(and I hope no-one used the i, j, h, w arguments as named arguments, or else this would be a BC-breaking change)

@fmassa fmassa merged commit e8d3291 into pytorch:master Sep 30, 2019
@fmassa fmassa mentioned this pull request Sep 30, 2019
Closed
@pmeier pmeier deleted the fix_crop_doc branch September 30, 2019 12:31
@pmeier pmeier mentioned this pull request Nov 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possible inversion of x-axis and y-axis in crop transform
2 participants
@pmeier @fmassa