Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DeprecationWarning for collections.Iterable import #1417

Merged
merged 2 commits into from
Oct 7, 2019
Merged

Fix DeprecationWarning for collections.Iterable import #1417

merged 2 commits into from
Oct 7, 2019

Conversation

adamjstewart
Copy link
Contributor

In Python 3.7, when you run the following import:

from collections import Iterable

you see the following deprecation warning:

DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

This PR future-proofs the LSUN dataset by importing Iterable from the new collections.abc module. This should allow the LSUN dataset to work with Python 3.8 when it is released. See also #600.

fmassa
fmassa approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit a141363 into pytorch:master Oct 7, 2019
@adamjstewart adamjstewart deleted the datasets/lsun branch October 7, 2019 14:07
@fmassa fmassa mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjstewart @fmassa