extend video reader to support fast video probing #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
requested changes
Oct 9, 2019
There was a problem hiding this comment.
Thanks for the PR!
This is ok for now, but I think we should probably refactor in the future the way we expose those attributes properties.
Also, C++ linter is failing in https://travis-ci.org/pytorch/vision/jobs/595456375, could you fix it?
The osx_wheel failures are unrelated to this PR.
Once linter is fixed this is good to merge.
Codecov Report
@@ Coverage Diff @@
## master #1437 +/- ##
==========================================
+ Coverage 64.01% 64.11% +0.09%
==========================================
Files 80 80
Lines 6308 6325 +17
Branches 968 970 +2
==========================================
+ Hits 4038 4055 +17
+ Misses 1989 1984 -5
- Partials 281 286 +5
Continue to review full report at Codecov.
|
|
@fmassa Make sense. Let's do it in the next refactoring PR. |
stephenyan1231
force-pushed
the
video_reader_video_probing
branch
from
f5cf884 to
f4708cf
Compare
facebook-github-bot
pushed a commit
to facebookresearch/ClassyVision
that referenced
this pull request
Oct 16, 2019
Summary: Pull Request resolved: #62 Current dependency torchvision 0.4.0 was released in August. It missed quite a few PRs that are merged after that, and that are needed for video classification, such as - pytorch/vision#1437 - pytorch/vision#1431 - pytorch/vision#1423 - pytorch/vision#1418 - pytorch/vision#1408 - pytorch/vision#1376 - pytorch/vision#1363 - pytorch/vision#1353 - pytorch/vision#1303 This will fail the CI test when a diff uses changes made in those PRs. Before a new official version of TorchVision is released, we can temporarily use the nightly torchvision to get all the recent PRs, and unblock the PR merging. We plan to use a fixed version of TorchVision later. Reviewed By: vreis Differential Revision: D17944239 fbshipit-source-id: 86ff540e3fc4f08ef767e84ef103525db5158201
fmassa
pushed a commit
that referenced
this pull request
Oct 31, 2019
* extend video reader to support fast video probing * fix c++ lint * small fix * allow to accept input video of type torch.Tensor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extend video reader to support probing the video quickly for getting video meta information
iomodule, add new methods_probe_video_from_fileand_probe_video_from_memoryunit test
python test/test_video_reader.pypython test/test_io.py