Temporary fix to remove ffmpeg from build time #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezyang
approved these changes
Oct 16, 2019
|
Thanks for doing it to unblock nightly build from ffmpeg dependency. @fmassa |
fmassa
added a commit
that referenced
this pull request
Oct 31, 2019
* Fix cherry-pick conflict for 0.4.2 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should enable us to get back into a state where we can build nightlies for torchvision.
This is temporary until we add a switch that makes CI depend on ffmpeg during PR testing but not for nightlies / binary build.
Note that we still build with ffmpeg on TravisCI, so this should give some signal.
cc @stephenyan1231