Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Updated assert in test_backbone_utils #1494

Merged
merged 1 commit into from
Oct 18, 2019
Merged

test: Updated assert in test_backbone_utils #1494

merged 1 commit into from
Oct 18, 2019

Conversation

frgfm
Copy link
Contributor

@frgfm frgfm commented Oct 18, 2019

This PR updates all raw assert to the corresponding unittest.TestCase assert method for tests related to torchvision.models.detection.backbone_utils as suggested by #1483.
The specific test was run locally with success, any feedback is welcome!

@frgfm
test: Updated assert in test_backbone_utils
2ed8343 
Updated all raw asserts to corresponding unittest.TestCase.assert. See pytorch#1483
fmassa
fmassa approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit a7d6fa6 into pytorch:master Oct 18, 2019
@frgfm frgfm deleted the test-bbutils-assert branch October 22, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa fmassa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frgfm @fmassa