Fix deeplab #1508
Closed
Fix deeplab #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eellison
reviewed
Oct 21, 2019
|
|
||
| def forward(self, x): | ||
| size = x.shape[-2:] | ||
| x = super(ASPPPooling, self).forward(x) | ||
| # workaround while torchscript doesn't support overriding forward in nn.Sequential | ||
| x = getattr(self, '0')(x) |
There was a problem hiding this comment.
does self.0 not work here instead ? TorchScript doesn't support getattr
There was a problem hiding this comment.
self.0 is an invalid syntax in python unfortunately.
This is weird, because I tried compiling this code and running it, and it seemed to work fine and give the same result as the non-compiled version
|
Let me take a look at supporting sequentials with custom forwards in Torchscript and report back. |
|
Subsumed by #1575 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation to #1436
@eellison let me know if you think this could work. I've tried it locally and it seems to be ok.