Fix torchvision install due to zippeg egg #1536
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1489
When compiling torchvision with
zip_safe=True
viapython setup.py install
, setuptools would generate a zippeg egg file. This made it impossible for custom extensions (which have recently been added) to work, because they would need to be unzipped beforehand.This used to work with C++ extensions which relied on pybind11 because they were proper Python extensions, which were imported via
import torchvision._C
, and setuptools generated special code for handling it. This is not the case anymore with custom ops, which are just libs without any Python information.Thanks for @tangorn and @pedrofreire for raising up the issue and giving a repro.