Enable ONNX Test for MaskRcnn #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lara-hdr
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1613 +/- ##
==========================================
+ Coverage 65.97% 66.03% +0.06%
==========================================
Files 91 91
Lines 7229 7229
Branches 1095 1095
==========================================
+ Hits 4769 4774 +5
+ Misses 2153 2150 -3
+ Partials 307 305 -2
Continue to review full report at Codecov.
|
fmassa
approved these changes
Nov 26, 2019
| def test_mask_rcnn(self): | ||
| images, test_images = self.get_test_images() | ||
|
|
||
| model = models.detection.mask_rcnn.maskrcnn_resnet50_fpn(pretrained=True) | ||
| model = models.detection.mask_rcnn.maskrcnn_resnet50_fpn(pretrained=True, min_size=200, max_size=300) |
There was a problem hiding this comment.
For a follow-up PR, do you think it would be possible to remove the need for downloading the pre-trained weights in the tests?
| @@ -54,7 +54,7 @@ before_install: | |||
| - pip install typing | |||
| - | | |||
| if [[ $TRAVIS_PYTHON_VERSION == 3.6 ]]; then | |||
| pip install onnxruntime | |||
| pip install -q --user -i https://test.pypi.org/simple/ ort-nightly==1.0.0.dev1123 | |||
There was a problem hiding this comment.
Do you have an idea when the new stable version of the onnxruntime will be available?
There was a problem hiding this comment.
not sure, I will ask and let you know
|
@fmassa can we merge this? |
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MaskRcnn should now be exportable to ONNX.
For more information on exporting this model, follow instructions in : #1555 (comment)