Fix for loading models with num_batches_tracked in frozen batch norm #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
Jan 10, 2020
There was a problem hiding this comment.
LGTM, thanks @szagoruyko !
I need to fix CI first before merging this, I'll get it fixed soon.
szagoruyko
force-pushed
the
fix-frozen-bn-loading
branch
from
983bcc0 to
5bcc337
Compare
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
=========================================
- Coverage 0.28% 0.28% -0.01%
=========================================
Files 92 92
Lines 7337 7342 +5
Branches 1106 1107 +1
=========================================
Hits 21 21
- Misses 7308 7313 +5
Partials 8 8
Continue to review full report at Codecov.
|
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jan 28, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 28, 2020
Summary: Pull Request resolved: #1815 Reviewed By: javier-m Differential Revision: D19599121 Pulled By: fmassa fbshipit-source-id: 9ecc14d232ad3c32fbbf847c4241d4a3c6cd4692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wide_resnet model loading with frozen batch norm which unlike other resnets have num_batches_tracked buffer. Errors out in load_state_dict without this. Suggested by @fmassa