Fix for rotate fill with Images of type F #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
approved these changes
Jan 29, 2020
| @@ -1078,7 +1078,7 @@ def test_rotate(self): | |||
| def test_rotate_fill(self): | |||
| img = F.to_pil_image(np.ones((100, 100, 3), dtype=np.uint8) * 255, "RGB") | |||
|
|
|||
| modes = ("L", "RGB") | |||
| modes = ("L", "RGB", "F") | |||
| nums_bands = [len(mode) for mode in modes] | |||
| fill = 127 | |||
There was a problem hiding this comment.
Lets see if this works with mode=="F" and an int value >1.
There was a problem hiding this comment.
We can create F images with arbitrary float values in it, including > 1 it seems
PIL.Image.fromarray(np.full((10, 10), 5.))
Codecov Report
@@ Coverage Diff @@
## master #1828 +/- ##
======================================
Coverage 0.43% 0.43%
======================================
Files 92 92
Lines 7386 7386
Branches 1111 1111
======================================
Hits 32 32
Misses 7346 7346
Partials 8 8
Continue to review full report at Codecov.
|
fmassa
added a commit
to fmassa/vision-1
that referenced
this pull request
Jan 29, 2020
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 29, 2020
Summary: Pull Request resolved: #1829 Reviewed By: lerks Differential Revision: D19619779 Pulled By: fmassa fbshipit-source-id: 0a210f90d58102da59dfb8ab1b3f93c619d0507f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix which was introduced in #1760.
It turns out that whenever the image is of type
Fwe can't pass a tuple of one element forfillbut instead we need indeed to pass it as a number.cc @pmeier