Added __repr__ attribute to GeneralizedRCNNTransform #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added more details to default __repr__ attribute for printing.
Switched strings with syntax to f-strings.
fmassa
reviewed
Jan 30, 2020
Checked integrity of __repr__ attribute
Codecov Report
@@ Coverage Diff @@
## master #1834 +/- ##
=========================================
- Coverage 0.43% 0.43% -0.01%
=========================================
Files 92 92
Lines 7388 7396 +8
Branches 1112 1113 +1
=========================================
Hits 32 32
- Misses 7348 7356 +8
Partials 8 8
Continue to review full report at Codecov.
|
Fixed the formatted strings in the __repr__ integrity check for GeneralizedRCNNTransform
|
Thanks for the test! Tests for Python 3.5 are failing, probably because f-strings have been introduced in Python 3.6. Can you fix this? |
fmassa
requested changes
Feb 3, 2020
Switched back f-strings to .format syntax for Python3.5 compatibility.
Fixed multiple-line string syntax for compatibility
Fixed formatting of min_size argument of the resizing part
|
@fmassa I have no clue why the coverage of inception has changed, but all the other tests are passing! |
fmassa
approved these changes
Feb 4, 2020
fmassa
pushed a commit
to fmassa/vision-1
that referenced
this pull request
Jun 9, 2020
* feat: Added __repr__ attribute to GeneralizedRCNNTransform Added more details to default __repr__ attribute for printing. * fix: Put back relative imports * style: Fixed pep8 compliance Switched strings with syntax to f-strings. * test: Added test for GeneralizedRCNNTransform __repr__ Checked integrity of __repr__ attribute * test: Fixed unittest for __repr__ Fixed the formatted strings in the __repr__ integrity check for GeneralizedRCNNTransform * fix: Fixed f-strings for earlier python versions Switched back f-strings to .format syntax for Python3.5 compatibility. * fix: Fixed multi-line string Fixed multiple-line string syntax for compatibility * fix: Fixed GeneralizedRCNNTransform unittest Fixed formatting of min_size argument of the resizing part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at:
__repr__attribute to theGeneralizedRCNNTransformclassSuggestions are welcomed for the proposed formatting!
See #1786