-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced mean on dimensions 2,3 by adaptive_avg_pooling2d #1838
Conversation
…ation of 1, to remove hardcoded dimension ordering
This pull request is following this issue: #1773 Since |
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
========================================
Coverage ? 0.43%
========================================
Files ? 92
Lines ? 7389
Branches ? 1113
========================================
Hits ? 32
Misses ? 7349
Partials ? 8
Continue to review full report at Codecov.
|
I first used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* replaced mean on dimensions 2,3 by adaptive_avg_pooling2d with destination of 1, to remove hardcoded dimension ordering * replaced reshape command by torch.squeeze after global_avg_pool2d, which is cleaner * reshape rather than squeeze for BS=1 * remove import torch
) Summary: * replaced mean on dimensions 2,3 by adaptive_avg_pooling2d with destination of 1, to remove hardcoded dimension ordering * replaced reshape command by torch.squeeze after global_avg_pool2d, which is cleaner * reshape rather than squeeze for BS=1 * remove import torch Pull Request resolved: #2416 Reviewed By: zhangguanheng66 Differential Revision: D22432590 Pulled By: fmassa fbshipit-source-id: a335e8b9342833cfe02702ebea75041f09c4924e
with destination of 1 (which is a Pytorch way to implement GlobalAvgPooling2D), to remove hardcoded dimension ordering