Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explanation of coordinates format in docs for faster+mask rcnn #1868

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Better explanation of coordinates format in docs for faster+mask rcnn #1868

merged 1 commit into from
Feb 13, 2020

Conversation

Robylyon93
Copy link
Contributor

Change discussed in #1856 .

I propose to clarify the fact that ground-truth boxes in [x1, y1, x2, y2] format have:

  • x-values between 0 and W
  • y-values between 0 and H

The current description might be confusing since in general locations in a matrix are in format (row, col) instead of (col, row).

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you also send a PR for keypoint_rcnn.py?

@fmassa fmassa merged commit 819b2e9 into pytorch:master Feb 13, 2020
@Robylyon93
Copy link
Contributor Author

Sure! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants